Author	SHA1	Message	Date
Johannes Schindelin	5a4ac9002d	Add missing awaits (#379) ... * auth-helper: properly await replacement of the token value in the config After writing the `.extraheader` config, we manually replace the token with the actual value. This is done in an `async` function, but we were not `await`ing the result. In our tests, this commit fixes a flakiness we observed where `remote.origin.url` sometimes (very rarely, actually) is not set for submodules. Our interpretation is that the configs are in the process of being rewritten with the correct token value _while_ another `git config` that wants to set the `insteadOf` value is reading the config, which is currently empty. A more idiomatic way to fix this in Typescript would use `Promise.all()`, like this: await Promise.all( configPaths.map(async configPath => { core.debug(`Replacing token placeholder in '${configPath}'`) await this.replaceTokenPlaceholder(configPath) }) ) However, during review of https://github.com/actions/checkout/pull/379 it was decided to keep the `for` loop in the interest of simplicity. Reported by Ian Lynagh. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> * downloadRepository(): await the result of recursive deletions Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> * Ask ESLint to report floating Promises This rule is quite helpful in avoiding hard-to-debug missing `await`s. Note: there are two locations in `src/main.ts` that trigger warnings: the `run()` and the `cleanup()` function are called without `await` and without any `.catch()` clause. In the initial version of https://github.com/actions/checkout/pull/379, this was addressed by adding `.catch()` clauses. However, it was determined that this is boilerplate code that will need to be fixed in a broader way. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> * Rebuild This trick was brought to you by `npm ci && npm run build`. Needed to get the PR build to pass. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>	2020-11-03 09:44:09 -05:00
eric sciple	01aecccf73	group output (#191)	2020-03-27 13:12:15 -04:00
eric sciple	85b1f35505	changes to support ghes alpha release (#199)	2020-03-25 15:12:22 -04:00
eric sciple	9a3a9ade82	persist core.sshCommand for submodules (#184) ... * persist core.sshCommand for submodules * update verbiage; add comments * fail when submodules or ssh-key and fallback to REST API	2020-03-12 11:42:38 -04:00
eric sciple	b2e6b7ed13	add ssh support (#163)	2020-03-11 15:55:17 -04:00
eric sciple	80602fafba	convert SSH URL to HTTPS (#179)	2020-03-10 10:45:50 -04:00
eric sciple	422dc45671	add support for submodules (#173)	2020-03-05 14:21:59 -05:00
eric sciple	f219062370	more unit tests and corresponding refactoring (#174)	2020-03-02 11:33:30 -05:00